-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Load large Dropdown choices progressively on scroll #13805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abidlabs
wants to merge
18
commits into
main
Choose a base branch
from
fix/issue-13340-gr-dropdown-with-large-choices-list-is-4-slower-
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
34e9907
Limit visible Dropdown choices
abidlabs f13d293
add changeset
gradio-pr-bot 737ffdd
Update generated Dropdown API signature
abidlabs a701acd
Make Dropdown choice limit opt-in
abidlabs 7ae4657
Remove non-filterable Dropdown limit test
abidlabs e581da2
Merge branch 'main' into fix/issue-13340-gr-dropdown-with-large-choic…
abidlabs f1163ac
Merge remote-tracking branch 'origin/main' into fix/issue-13340-gr-dr…
abidlabs 5ef7467
Merge remote-tracking branch 'origin/fix/issue-13340-gr-dropdown-with…
abidlabs 61f8b19
Default Dropdown choice limit to 100
abidlabs 45a79e3
Merge remote-tracking branch 'origin/main' into fix/issue-13340-gr-dr…
abidlabs ea63ebe
Address dropdown limit review feedback
abidlabs d027a30
Load additional dropdown choices on scroll
abidlabs a8ef3dc
add changeset
gradio-pr-bot 385b3c1
Avoid injecting selected values into dropdown batches
abidlabs cec28d2
Merge branch 'main' into fix/issue-13340-gr-dropdown-with-large-choic…
abidlabs fb725c2
Merge remote-tracking branch 'origin/main' into fix/issue-13340-gr-dr…
abidlabs ad6cee4
Support progressive dropdown keyboard navigation
abidlabs 8459129
Merge remote-tracking branch 'origin/fix/issue-13340-gr-dropdown-with…
abidlabs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@gradio/dropdown": minor | ||
| "gradio": minor | ||
| --- | ||
|
|
||
| feat:Load large Dropdown choices progressively on scroll | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changeset was generated by
gradio-pr-bot(commits f13d293 and a8ef3dc), not hand-authored. Keeping the bot-generated file is consistent with the repository guidance and avoids replacing or fighting the automated changelog entry.