Skip to content

Prevent version less tags from downgrading#366

Merged
cobexer merged 1 commit intomasterfrom
cobexer/dont-downgrade-version-less-tags-across-gradle-versions
Sep 30, 2025
Merged

Prevent version less tags from downgrading#366
cobexer merged 1 commit intomasterfrom
cobexer/dont-downgrade-version-less-tags-across-gradle-versions

Conversation

@cobexer
Copy link
Copy Markdown
Member

@cobexer cobexer commented Sep 30, 2025

Make sure we don't generate version less tags that used to refer to Gradle 9+ images on older branches suddenly downgrading your Gradle version

Make sure we don't generate version less tags that used to refer to Gradle 9+ images on older branches suddenly downgrading your Gradle version

Signed-off-by: Christoph Obexer <cobexer@gradle.com>
@cobexer cobexer self-assigned this Sep 30, 2025
@cobexer cobexer requested review from a team as code owners September 30, 2025 09:27
@cobexer
Copy link
Copy Markdown
Member Author

cobexer commented Sep 30, 2025

The upstream diffing of the published images alerted me to this in docker-library/official-images#19972 (comment):

diff --git a/gradle_jdk24-corretto-al2023/Dockerfile b/gradle_jdk24-corretto-al2023/Dockerfile
index 1b41462..38cac6c 100644
--- a/gradle_jdk24-corretto-al2023/Dockerfile
+++ b/gradle_jdk24-corretto-al2023/Dockerfile
@@ -60,8 +60,8 @@ VOLUME /home/gradle/.gradle
 
 WORKDIR /home/gradle
 
-ENV GRADLE_VERSION=9.1.0
-ARG GRADLE_DOWNLOAD_SHA256=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806
+ENV GRADLE_VERSION=8.14.3
+ARG GRADLE_DOWNLOAD_SHA256=bd71102213493060956ec229d946beee57158dbd89d0e62b91bca0fa2c5f3531
 RUN set -o errexit -o nounset \
     && echo "Downloading Gradle" \
     && wget --no-verbose --output-document=gradle.zip "https://services.gradle.org/distributions/gradle-${GRADLE_VERSION}-bin.zip" \
diff --git a/gradle_jdk24-graal-noble/Dockerfile b/gradle_jdk24-graal-noble/Dockerfile
index 2ebdb47..2ebdb44 100644
--- a/gradle_jdk24-graal-noble/Dockerfile
+++ b/gradle_jdk24-graal-noble/Dockerfile
@@ -108,8 +108,8 @@ RUN set -o errexit -o nounset \
     && javac --version \
     && native-image --version
 
-ENV GRADLE_VERSION=9.1.0
-ARG GRADLE_DOWNLOAD_SHA256=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806
+ENV GRADLE_VERSION=8.14.3
+ARG GRADLE_DOWNLOAD_SHA256=bd71102213493060956ec229d946beee57158dbd89d0e62b91bca0fa2c5f3531
 RUN set -o errexit -o nounset \
     && echo "Downloading Gradle" \
     && wget --no-verbose --output-document=gradle.zip "https://services.gradle.org/distributions/gradle-${GRADLE_VERSION}-bin.zip" \

@cobexer cobexer merged commit 557df3e into master Sep 30, 2025
27 checks passed
@cobexer cobexer deleted the cobexer/dont-downgrade-version-less-tags-across-gradle-versions branch September 30, 2025 09:31
@keeganwitt
Copy link
Copy Markdown
Collaborator

Why would this be needed after the directories have been deleted in the older branches as well as master?

@cobexer
Copy link
Copy Markdown
Member Author

cobexer commented Oct 1, 2025

@keeganwitt we only deleted images that were no longer there, thus

- jdk24-corretto
- jdk24-noble-graal

are still there until they get removed upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants