Prevent version less tags from downgrading#366
Merged
Conversation
Make sure we don't generate version less tags that used to refer to Gradle 9+ images on older branches suddenly downgrading your Gradle version Signed-off-by: Christoph Obexer <cobexer@gradle.com>
ov7a
approved these changes
Sep 30, 2025
Member
Author
|
The upstream diffing of the published images alerted me to this in docker-library/official-images#19972 (comment): diff --git a/gradle_jdk24-corretto-al2023/Dockerfile b/gradle_jdk24-corretto-al2023/Dockerfile
index 1b41462..38cac6c 100644
--- a/gradle_jdk24-corretto-al2023/Dockerfile
+++ b/gradle_jdk24-corretto-al2023/Dockerfile
@@ -60,8 +60,8 @@ VOLUME /home/gradle/.gradle
WORKDIR /home/gradle
-ENV GRADLE_VERSION=9.1.0
-ARG GRADLE_DOWNLOAD_SHA256=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806
+ENV GRADLE_VERSION=8.14.3
+ARG GRADLE_DOWNLOAD_SHA256=bd71102213493060956ec229d946beee57158dbd89d0e62b91bca0fa2c5f3531
RUN set -o errexit -o nounset \
&& echo "Downloading Gradle" \
&& wget --no-verbose --output-document=gradle.zip "https://services.gradle.org/distributions/gradle-${GRADLE_VERSION}-bin.zip" \
diff --git a/gradle_jdk24-graal-noble/Dockerfile b/gradle_jdk24-graal-noble/Dockerfile
index 2ebdb47..2ebdb44 100644
--- a/gradle_jdk24-graal-noble/Dockerfile
+++ b/gradle_jdk24-graal-noble/Dockerfile
@@ -108,8 +108,8 @@ RUN set -o errexit -o nounset \
&& javac --version \
&& native-image --version
-ENV GRADLE_VERSION=9.1.0
-ARG GRADLE_DOWNLOAD_SHA256=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806
+ENV GRADLE_VERSION=8.14.3
+ARG GRADLE_DOWNLOAD_SHA256=bd71102213493060956ec229d946beee57158dbd89d0e62b91bca0fa2c5f3531
RUN set -o errexit -o nounset \
&& echo "Downloading Gradle" \
&& wget --no-verbose --output-document=gradle.zip "https://services.gradle.org/distributions/gradle-${GRADLE_VERSION}-bin.zip" \
|
Collaborator
|
Why would this be needed after the directories have been deleted in the older branches as well as master? |
Member
Author
|
@keeganwitt we only deleted images that were no longer there, thus docker-gradle/.github/workflows/ci.yaml Lines 48 to 49 in 23cd8c0 are still there until they get removed upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure we don't generate version less tags that used to refer to Gradle 9+ images on older branches suddenly downgrading your Gradle version