-
Notifications
You must be signed in to change notification settings - Fork 74
Improve Maintenance Scripts #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8ef7290
Whitespace cleanup
cobexer 084bb8b
Reduce duplication in `update.py`
cobexer 7ab136f
Initial plan
Copilot 42abe17
Rename fetch_graalvm_version to fetch_graalvm_release_info
Copilot f7b1d6e
Add __pycache__ to .gitignore and remove from tracking
Copilot 4312444
Merge pull request #389 from gradle/copilot/sub-pr-388
cobexer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetch_graalvm_versionnow returns a tuple of (version, amd64_sha, aarch64_sha), so the name is misleading and can cause callers to assume it only returns the version. Consider renaming it to reflect the full payload (e.g.,fetch_graalvm_release_info/fetch_graalvm_checksums) or returning a small dict/dataclass for clarity.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request to apply changes based on this feedback