Add onRetry for setting JVM options for fork differently#349
Open
U1F984 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Leo Tietz <leo.tietz@gmail.com>
U1F984
force-pushed
the
retry-different-system-properties
branch
from
73849a9 to
df452eb
Compare
Member
|
@U1F984 , thank you for looking into it. I am not convinced that we'll go down this route. It does not cover some of the use cases from #271, like "Print a message on successful retry". Furthermore, we need to think more about the semantics of this callback: should it be invoked once, meaning that the test retry plugin kicked in, or on every retry? I am sorry it takes us so long to get to this topic. We still plan to investigate it, but we'll need to see first how it ranks against other priorities. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #205, #206, #209, #271.
Going by my last submitted PR I don't expect this one to be accepted either, so I've not bothered to add any tests/docs.