[UPDATE] update to grpc-swift-2. #59
Conversation
WalkthroughThe package manifest was updated to change the gRPC Swift package source URL, raise the minimum version requirements for the gRPC Swift NIO transport and protobuf dependencies, and update the related target dependency reference. No other dependency or target changes were made. Changes
Estimated code review effort1 (~2 minutes) Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Package.swift(2 hunks)
🔇 Additional comments (1)
Package.swift (1)
31-33: Ignore invalid repo existence concernBoth
https://github.com/grpc/grpc-swift-2.gitandhttps://github.com/grpc/grpc-swift.gitare reachable viagit ls-remote; no changes to your Package.swift are needed.Likely an incorrect or invalid review comment.
| .package(url: "https://github.com/grpc/grpc-swift-2.git", from: "2.0.0"), | ||
| .package(url: "https://github.com/grpc/grpc-swift-nio-transport.git", from: "2.0.0"), | ||
| .package(url: "https://github.com/grpc/grpc-swift-protobuf.git", from: "2.0.0"), |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Confirm that grpc-swift-nio-transport & grpc-swift-protobuf have 2.0.0 tags
These satellite repos only recently started publishing separate tags; if 2.0.0 is not yet pushed the resolver will break.
Keep the bump but guard with an upper-bound (upToNextMajor) or pin after verifying the tag exists.
🤖 Prompt for AI Agents
In Package.swift around lines 31 to 33, the dependencies
grpc-swift-nio-transport and grpc-swift-protobuf are set to version "2.0.0"
without confirming if that tag exists, which may cause resolution failures.
Verify that the "2.0.0" tags are published for these repos, then update the
package declarations to use a version range with an upper bound using
.upToNextMajor(from: "2.0.0") to prevent future breaking changes, or pin to a
specific commit if the tag is missing.
| name: "GRPCEncapsulates", | ||
| dependencies: [ | ||
| .product(name: "GRPCCore", package: "grpc-swift"), | ||
| .product(name: "GRPCCore", package: "grpc-swift-2"), |
There was a problem hiding this comment.
Package identity mismatch may break product lookup
You renamed the package to grpc-swift-2, but the actual identity (if the original URL is kept) will be grpc-swift.
If you revert the URL as suggested, also revert this line to keep identities aligned:
- .product(name: "GRPCCore", package: "grpc-swift-2"),
+ .product(name: "GRPCCore", package: "grpc-swift"),Failing to do so will produce
error: unknown package 'grpc-swift-2' in dependencies of target 'GRPCEncapsulates'.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| .product(name: "GRPCCore", package: "grpc-swift-2"), | |
| .product(name: "GRPCCore", package: "grpc-swift"), |
🤖 Prompt for AI Agents
In Package.swift at line 55, the product name references "grpc-swift-2" which
does not match the actual package identity if the original URL is kept as
"grpc-swift". To fix this, revert the product name back to "grpc-swift" to align
with the package identity and avoid the unknown package error during product
lookup.
1 participant
Summary by CodeRabbit