This repository was archived by the owner on Jun 5, 2026. It is now read-only.
ingress tls support#680
Open
dsociative wants to merge 5 commits into
Open
Conversation
|
|
simonswine
approved these changes
May 12, 2023
simonswine
left a comment
simonswine
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Thanks for the contribution
Contributor
|
@dsociative in order to get a release of a new helm chart version, could you raise the version of the helm chart here: |
cyriltovena
reviewed
May 12, 2023
| @@ -38,4 +48,4 @@ spec: | |||
| path: /push.v1.PusherService/ | |||
Contributor
There was a problem hiding this comment.
Unrelated to this PR: We need to add the new pyroscope path I think.
Contributor
There was a problem hiding this comment.
Author
|
@simonswine done |
auto-merge was automatically disabled
May 12, 2023 13:02
Head branch was pushed to by a user without write access
Contributor
|
@dsociative The helm manifests need to update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tls support to ingress template