Skip to content
This repository was archived by the owner on Jun 5, 2026. It is now read-only.

Make content in tooltip better visual experience.#286

Open
timoyan wants to merge 1 commit into
grafana-cold-storage:masterfrom
timoyan:feature/adjust-color-base-theme
Open

Make content in tooltip better visual experience.#286
timoyan wants to merge 1 commit into
grafana-cold-storage:masterfrom
timoyan:feature/adjust-color-base-theme

Conversation

@timoyan

@timoyan timoyan commented Nov 16, 2020

Copy link
Copy Markdown

Take different color in different theme (dark and light).

Current is really not very clear in light mode because font color and background color are too simliar.

@CLAassistant

CLAassistant commented Nov 16, 2020

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@timoyan

timoyan commented Nov 16, 2020

Copy link
Copy Markdown
Author

Btw, I try to run Run linter/prettier: npx grafana-toolkit plugin:dev according to https://github.com/panodata/grafana-map-panel/blob/develop/CONTRIBUTING.md
Found there is 9 places need to be fixed which not belongs to this pull request change, should I submit?

@amotl

amotl commented Nov 16, 2020

Copy link
Copy Markdown

Dear Timo,

thanks for your contribution. Our fork grafana-map-panel includes the improvement #191 by @dtheb (see also #169), amongst many others. See also #281.

With kind regards,
Andreas.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants