[loki] Generate Dashboards from loki-mixin by jkroepke · Pull Request #193 · grafana-community/helm-charts

jkroepke · 2026-03-22T11:56:35Z

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes [loki] Dashboards for Distributed mode #181

Special notes for your reviewer

Checklist

DCO signed
Chart Version bumped
Title of the PR starts with chart name (e.g. [grafana])

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

charts/loki/hack/sync_grafana_dashboards.py

QuentinBisson

At a first glance LGTM

TheRealNoob · 2026-03-28T08:23:17Z

charts/loki/values.yaml

    # -- If enabled, create PrometheusRule resources with Loki recording rules
    enabled: false

    configs:


One of the things I remember is that this logic on configs.<alert_name>.lookbackPeriod and threshold won't scale to all alerts. It works for simple alerts, but won't scale if loki-mixin decides to add a more advanced query. For example

foo[5m] > 0 and bar[10m] != 2

So I was going to look at removing these. And furthermore I was going to restructure .config to match KPS's implementation.

ah it looks like you've dropped support for the config block already

I do not touch alerts here, only recording rules.

charts/loki/templates/monitoring/rules/loki_rules.yaml

TheRealNoob · 2026-03-28T08:26:23Z

charts/loki/values.yaml

    labels:
      grafana_dashboard: "1"
+    multiCluster:
+      # -- Enable multi-cluster support for the dashboards.


is this cluster term used to define kubernetes clusters or loki clusters? I assume it's loki cluster meaning support for multiple loki helm chart releases. it's an overused term and I wish mimir/loki had chosen something else.

I don't know how feasiable it is, but I recall wishing in the past that we could change the term. Though I suspect this change would have to start at the loki-mixin.

Kubernetes cluster.

at least in the current implementation of the dashboards in the chart, the cluster drop-down variable uses the cluster variable. which is what's defined in the serviceMonitor. So implementing this will probably cause both k8s cluster names and loki cluster names to be returned in the drop-down. so perhaps we want to hold-off on implementing this until the overlap is addressed.

I would say to address the overlap in this PR, but like I said the change will have to start in the loki-mixin. Unless you want to substitute it from the dashboard configmaps via python.

Any thoughts on the label to use instead? I was thinking lokiRelease or releaseName? perhaps the second that way we can use the same variable across mimir/loki/tempo

I'm willing to open the PR against loki-mixin. I've recently learned jsonnet. At least enough to do this PR. I'll make the variable configurable, as I suspect they'll ask for backwards compatibility. Depending on what the default is set to.

I have no idea. Generally cluster label is used for Kubernetes Cluster. Loki should use loki_cluster.

Loki_cluster makes sense here to not overlap with the regular k8s cluster label. But I recall this can already be changed using a custom jsonnet config file

oh that's good, didn't know that. I however lean towards a single label that can be re-used across tempo/mimir/loki.

TheRealNoob · 2026-03-28T08:27:03Z

charts/loki/values.yaml

I would appreciate some time to test it so I can visualize the changes

Sure, community is invited as well. cc @marcofranssen

charts/loki/templates/monitoring/rules/loki_rules.yaml

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

set prefix until grafana-community/helm-charts#193 is implemented

* feat(deps): update helm release k8s-monitoring to v4 BREAKING CHANGE: k8s-monitoring: adjust your custom values according to https://github.com/grafana/k8s-monitoring-helm/tree/main/charts/k8s-monitoring#version-40 (or contact kubrix support) * Refactor k8s-monitoring configuration and remove alloy metrics * Update values-kubrix-default.yaml * Update values-kubrix-default.yaml * Update values-kubrix-default.yaml * Update values-kubrix-default.yaml * Update values-kubrix-default.yaml * Update values-kubrix-default.yaml * Update values-kubrix-default.yaml * Update values-kubrix-default.yaml * Update values-kubrix-default.yaml * Update values-kubrix-default.yaml * Update values-kubrix-default.yaml * Update values-kubrix-default.yaml set prefix until grafana-community/helm-charts#193 is implemented * Update values-kubrix-default.yaml --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Johannes Kleinlercher <johannes.kleinlercher@suxess-it.com>

jkroepke mentioned this pull request Mar 22, 2026

[loki] Make ServiceMonitor jobPrefix configurable #192

Merged

3 tasks

jkroepke force-pushed the jsonnet branch from 3973536 to 68a61f0 Compare March 23, 2026 12:43

jkroepke mentioned this pull request Mar 26, 2026

[loki] Dashboards for Distributed mode #181

Open

jkroepke force-pushed the jsonnet branch 4 times, most recently from 8dc3f4d to 18901ef Compare March 27, 2026 10:17

[loki] Generate Dashboards from loki-mixin

ba57674

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

jkroepke force-pushed the jsonnet branch from 0ce1b00 to ba57674 Compare March 28, 2026 06:14

jkroepke marked this pull request as ready for review March 28, 2026 06:16

jkroepke requested review from QuentinBisson and TheRealNoob as code owners March 28, 2026 06:16

QuentinBisson reviewed Mar 28, 2026

View reviewed changes

charts/loki/hack/sync_grafana_dashboards.py Show resolved Hide resolved

QuentinBisson previously approved these changes Mar 28, 2026

View reviewed changes

TheRealNoob reviewed Mar 28, 2026

View reviewed changes

charts/loki/templates/monitoring/rules/loki_rules.yaml Outdated Show resolved Hide resolved

[loki] Generate Dashboards from loki-mixin

8895b9f

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

jkroepke dismissed QuentinBisson’s stale review via 8895b9f March 28, 2026 16:08

jkroepke added 2 commits March 28, 2026 17:15

[loki] Generate Dashboards from loki-mixin

bce9e39

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

Merge branch 'main' into jsonnet

dd9f8f9

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

TheRealNoob self-assigned this Apr 3, 2026

jkleinlercher added a commit to suxess-it/kubriX that referenced this pull request Apr 7, 2026

Update values-kubrix-default.yaml

f6f4954

set prefix until grafana-community/helm-charts#193 is implemented

Conversation

jkroepke commented Mar 22, 2026

What this PR does / why we need it

Which issue this PR fixes

Special notes for your reviewer

Checklist

Uh oh!

Uh oh!

QuentinBisson left a comment

Choose a reason for hiding this comment

Uh oh!

TheRealNoob Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TheRealNoob Mar 28, 2026 •

edited

Loading