Skip to content

[loki] Add workload template helper for compactor#238

Open
jkroepke wants to merge 12 commits intografana-community:mainfrom
jkroepke:distrobutor
Open

[loki] Add workload template helper for compactor#238
jkroepke wants to merge 12 commits intografana-community:mainfrom
jkroepke:distrobutor

Conversation

@jkroepke
Copy link
Copy Markdown
Member

@jkroepke jkroepke commented Apr 1, 2026

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [grafana])

@jkroepke jkroepke force-pushed the distrobutor branch 2 times, most recently from 00dc533 to e32db72 Compare April 3, 2026 13:39
jkroepke added 4 commits April 3, 2026 21:48
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke marked this pull request as ready for review April 3, 2026 20:59
jkroepke added 4 commits April 3, 2026 23:02
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

## Upgrading

### 9.6.0
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should we use 10 here? Statefulsets... we should use Deployments for Upcoming Loki 4...

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this requires a breaking change unless you want to add a job that can run this on upgrade

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheRealNoob Whats your thoughts? Technically, values dont break, but end-users created manually delete StatefulSets.

Similiar to 6.34 and 6.38 updates

Ref: https://grafana.com/docs/loki/latest/setup/upgrade/upgrade-to-6x/#breaking-zone-aware-ingester-statefulset-servicename-fix-6340

In a future version, we should go with Deployments and ephemeral volumes.

jkroepke added 4 commits April 4, 2026 09:39
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants