[loki] Add template helper for single-binary#303
[loki] Add template helper for single-binary#303jkroepke wants to merge 3 commits intografana-community:mainfrom
Conversation
jkroepke
force-pushed
the
single-binary
branch
3 times, most recently
from
a3dfcb6 to
d7bf165
Compare
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
| {{- if ne $target "canary" }} | ||
| - -config.file=/etc/loki/config/config.yaml | ||
| - -target={{ $target }}{{- if and .Values.loki.ui.enabled (or (eq $target "read") (eq $target "query-frontend") (eq $target "querier")) }},ui{{- end }} | ||
| - -target={{ replace "single-binary" "all" $target }}{{- if and .Values.loki.ui.enabled (or (eq $target "read") (eq $target "query-frontend") (eq $target "querier")) }},ui{{- end }} |
There was a problem hiding this comment.
Does all contains the ui target?
| {{- else }} | ||
| - name: http-metrics | ||
| containerPort: 3100 | ||
| containerPort: {{ .Values.loki.server.http_listen_port }} |
There was a problem hiding this comment.
Why are we suddenly introducting _ instead of camel case here?
There was a problem hiding this comment.
I'm not introducing new things.
However, it makes sense, because the Loki configuration key is http_listen_port
| # -- Number of replicas for the single binary | ||
| replicas: 0 | ||
| # -- Whether to enable the rules sidecar | ||
| sidecar: true |
There was a problem hiding this comment.
Maybe this should be a separate pr so the changelog is easier to review?
There was a problem hiding this comment.
This is necessary to avoid an breaking Change.
The current condition is:
The current condition on the pod template is:
helm-charts/charts/loki/templates/_pod.tpl
Lines 284 to 286 in 55a4989
Without sidecar=true, the sidecar would be disappear.
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
2 participants
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[grafana])