[loki] Fix ServiceAccount resource name#319
Merged
jkroepke merged 8 commits intografana-community:mainfrom Apr 10, 2026
Merged
Conversation
vquie
requested review from
QuentinBisson,
TheRealNoob and
jkroepke
as code owners
vquie
force-pushed
the
fix_serviceaccount_resource_name
branch
from
5eed70a to
dea3f5a
Compare
jkroepke
requested changes
Apr 10, 2026
Use loki.serviceAccountName helper with component and target Add tests for backend serviceAccount.name override Bump chart version to 11.4.7 Signed-off-by: Vitali Quiering <21147643+vquie@users.noreply.github.com>
Signed-off-by: Vitali Quiering <21147643+vquie@users.noreply.github.com>
vquie
force-pushed
the
fix_serviceaccount_resource_name
branch
from
7b84b47 to
0087d9d
Compare
Deleted outdated guidance for chart contribution Information is now covered in existing repository docs Signed-off-by: Vitali Quiering <21147643+vquie@users.noreply.github.com>
Signed-off-by: Vitali Quiering <21147643+vquie@users.noreply.github.com>
vquie
force-pushed
the
fix_serviceaccount_resource_name
branch
from
bfcd12c to
1d98ef9
Compare
jkroepke
reviewed
Apr 10, 2026
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
jkroepke
reviewed
Apr 10, 2026
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
jkroepke
approved these changes
Apr 10, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
serviceAccount.name didn't override the serviceaccount resource's name
Now it does.
Special notes for your reviewer
Checklist
[grafana])