[loki] Fix loki ruler directories mount#323
Merged
jkroepke merged 11 commits intografana-community:mainfrom Apr 10, 2026
Merged
[loki] Fix loki ruler directories mount#323jkroepke merged 11 commits intografana-community:mainfrom
jkroepke merged 11 commits intografana-community:mainfrom
Conversation
Render configMap-backed rule volumes for ruler when sidecar.rules.enabled is false Ensure sidecar volumes and mounts are skipped if disabled Add tests validating ruler directories without sidecar Signed-off-by: Vitali Quiering <21147643+vquie@users.noreply.github.com>
Updates Helm chart version for latest Loki release Signed-off-by: Vitali Quiering <21147643+vquie@users.noreply.github.com>
vquie
requested review from
QuentinBisson,
TheRealNoob and
jkroepke
as code owners
Signed-off-by: Vitali Quiering <21147643+vquie@users.noreply.github.com>
vquie
force-pushed
the
loki-ruler-directories-mount
branch
from
eed6a44 to
d9eb782
Compare
jkroepke
requested changes
Apr 10, 2026
Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: VQuie <21147643+vquie@users.noreply.github.com>
Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: VQuie <21147643+vquie@users.noreply.github.com>
Signed-off-by: Vitali Quiering <21147643+vquie@users.noreply.github.com>
Corrected has usage to pass $target as first argument Ensures proper evaluation for ruler, backend, single-binary targets Signed-off-by: Vitali Quiering <21147643+vquie@users.noreply.github.com>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The
ruler.directorieswhere not mounted even thoughloki.rulerConfig.storagewas defined.This PR fixes this and recreates previous behavior.
Special notes for your reviewer
Checklist
[grafana])