Skip to content

[tempo-distributed] Add more extra containers options for tempo distributed#51

Merged
Sheikh-Abubaker merged 1 commit intografana-community:mainfrom
deejay1:more-extra-containers
Feb 8, 2026
Merged

[tempo-distributed] Add more extra containers options for tempo distributed#51
Sheikh-Abubaker merged 1 commit intografana-community:mainfrom
deejay1:more-extra-containers

Conversation

@deejay1
Copy link
Copy Markdown

@deejay1 deejay1 commented Feb 6, 2026

What this PR does / why we need it

Allows for setting more extra containers for parts of the stack, needed for sidecars and proxies.

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@deejay1 deejay1 force-pushed the more-extra-containers branch from ce16863 to 69cbca1 Compare February 6, 2026 18:44
@deejay1 deejay1 marked this pull request as ready for review February 6, 2026 19:22
Copy link
Copy Markdown

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deejay1 Thank you for your contribution, I'd recommend splitting the rollout operator bump into another PR

@deejay1
Copy link
Copy Markdown
Author

deejay1 commented Feb 6, 2026

@Sheikh-Abubaker Hi, the rollout operator is on this version already, this only syncs the Readme to Chart.lock

Edit: https://github.com/grafana-community/helm-charts/blob/main/charts/tempo-distributed/Chart.lock#L10
Was updated in f35b93f but README wasn't updated then.

@Sheikh-Abubaker
Copy link
Copy Markdown

Sheikh-Abubaker commented Feb 8, 2026

Edit: https://github.com/grafana-community/helm-charts/blob/main/charts/tempo-distributed/Chart.lock#L10 Was updated in f35b93f but README wasn't updated then.

Oh, I see! but it would be better to separate a bug and feature change into different PRs, as in the context of this PR, it is introducing a new extraContainers: [] feature that should be followed by a minor version bump of the chart and you could then raise a new PR that specifically address the README bug, followed by a patch version bump.

@deejay1 deejay1 force-pushed the more-extra-containers branch 3 times, most recently from 5bb32f8 to 16984c6 Compare February 8, 2026 15:46
Signed-off-by: Łukasz Jernaś <lukasz.jernas@allegro.com>
@deejay1 deejay1 force-pushed the more-extra-containers branch from 16984c6 to 52a8b8d Compare February 8, 2026 15:47
@deejay1
Copy link
Copy Markdown
Author

deejay1 commented Feb 8, 2026

you could then raise a new PR that specifically address the README bug, followed by a patch version bump.
Ok, after this get merged I'll do a new PR, as there are multiple READMEs to be updated anyway

@Sheikh-Abubaker Sheikh-Abubaker merged commit 606663c into grafana-community:main Feb 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants