Skip to content

Update .helmignore#65

Closed
TheRealNoob wants to merge 8 commits intografana-community:mainfrom
TheRealNoob:update-helmignore
Closed

Update .helmignore#65
TheRealNoob wants to merge 8 commits intografana-community:mainfrom
TheRealNoob:update-helmignore

Conversation

@TheRealNoob
Copy link
Copy Markdown
Member

What this PR does / why we need it

updates .helmignore files, which does two things

  • standardizes our ignores
  • allows us to modify README.md and README.md.gotmpl without needing to bump the Chart version

Which issue this PR fixes

None

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@TheRealNoob
Copy link
Copy Markdown
Member Author

as ironic as this is, it was necessary to bump the chart versions in this case. Because our CI releases the charts on every merge to main. And we previously released these charts containing all newly blacklisted files. And we don't want to re-release the versions with new contents. But it won't be an issue moving forward.

@TheRealNoob
Copy link
Copy Markdown
Member Author

I'll wait for feedback from maintainers before I open this up as a bunch of separate PRs. If there's consensus to go ahead then I'll open and merge those, linking back here.

Copy link
Copy Markdown
Member

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: TheRealNoob <mike1118@live.com>
Signed-off-by: TheRealNoob <mike1118@live.com>
Signed-off-by: TheRealNoob <mike1118@live.com>
Signed-off-by: TheRealNoob <mike1118@live.com>
Signed-off-by: TheRealNoob <mike1118@live.com>
Signed-off-by: TheRealNoob <mike1118@live.com>
Copy link
Copy Markdown

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealNoob
Copy link
Copy Markdown
Member Author

forked into separate PRs for each chart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants