[CI] fix issue-triage template#95
Conversation
Signed-off-by: TheRealNoob <mike1118@live.com>
|
An alternative would be adding "ALL" to indicate non helm chart issues |
|
You mean like an additional item on the list? I considered it, we certainly could, but i think a blank entry on the list communicates it just as well. At least that's how I expect this will turn out, but I haven't been able to see an example firsthand. |
|
Keep it required as is. Non related chart issues can be created through an blank issue. |
|
then we need to rename the existing issue templates to communicate that the forms are for helm charts only. as-is i guarantee someone will see "bug report" and think it applies to all bugs. same for features. I think it'd be easier for us and users to make the field optional. |
|
What a use case for a non helm chart related bug? |
|
CI bug publishing OCI images, feature request to enforce helm-docs re-generation, proposal to delete helm-docs. Just a few examples we've seen already. There will always be non-helm-chart related issues coming in, albeit slowly. As I think about it though, I am starting to agree with you that our existing bug/feature forms are heavily aimed at helm charts. So maybe it makes sense to rename them as "chart only", so long as that's a decision being made consciously. |
|
the chart only rename make sense to me. |
Signed-off-by: TheRealNoob <mike1118@live.com>
|
implemented what we discussed |
What this PR does / why we need it
I realized that the Issue template forms require a chart selection, which is incompatible with non-helm-chart issues. I thought about making dedicated forms for helm-charts and non-helm-charts but that's a bigger project and I'm not sure there's enough of a difference yet. pre-mature optimization. So I just made them optional. I believe everything else in place should still work.
Which issue this PR fixes
Special notes for your reviewer
Checklist
[grafana])