-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix doc "collect/metamonitoring": relocate 'replace prometheus.exporter.self "<SELF_LABEL>" instruction' to correct location #2997
Merged
clayton-cornell
merged 1 commit into
grafana:main
from
edv1n:fix-doc-collect-metamonitoring
Mar 14, 2025
Merged
fix doc "collect/metamonitoring": relocate 'replace prometheus.exporter.self "<SELF_LABEL>" instruction' to correct location #2997
clayton-cornell
merged 1 commit into
grafana:main
from
edv1n:fix-doc-collect-metamonitoring
Mar 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us.exporter.self <SELF_LABEL> to correct location
clayton-cornell
approved these changes
Mar 14, 2025
clayton-cornell
approved these changes
Mar 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this. Approving and merging.
clayton-cornell
pushed a commit
that referenced
this pull request
Mar 14, 2025
…us.exporter.self <SELF_LABEL> to correct location (#2997) (#3003) (cherry picked from commit f161963) Co-authored-by: Edwin S <[email protected]>
clayton-cornell
pushed a commit
that referenced
this pull request
Mar 14, 2025
…us.exporter.self <SELF_LABEL> to correct location (#2997) (#3005) (cherry picked from commit f161963) Co-authored-by: Edwin S <[email protected]>
clayton-cornell
pushed a commit
that referenced
this pull request
Mar 14, 2025
…us.exporter.self <SELF_LABEL> to correct location (#2997) (#3004) (cherry picked from commit f161963) Co-authored-by: Edwin S <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport release/v1.5
backport release/v1.6
backport release/v1.7
type/docs
Docs Squad label across all Grafana Labs repos
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
fix doc collect/metamonitoring that:
The instruction of
should be under the code block of
instead of the code block of
Which issue(s) this PR fixes
This PR is a trivial fix, no issue is required according to the Contributing guideline
Notes to the Reviewer
I found the instruction of replacing the <SELF_LABEL> under step 2 is a bit difficult to follow, so I suggest changing it to step 1. I have also checked the doc of collect/datadog-traces-metrics to ensure consistency.
PR Checklist
I am not sure if I need to update the CHANGELOG.md as this is just a small fix of the documentation.