feat(prometheus.exporter.azure): expose concurrency settings #4951
+164
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
akselleirv
force-pushed
the
azureexposeconcurrencysettings
branch
from
68a5cf4 to
bb53c49
Compare
docs/sources/reference/components/prometheus/prometheus.exporter.azure.md
Outdated
Show resolved
Hide resolved
clayton-cornell
added
the
type/docs
…er.azure.md Co-authored-by: Clayton Cornell <[email protected]>
kgeckhart
reviewed
Dec 10, 2025
| concurrencyConfig := azure_config.Opts{} | ||
| concurrencyConfig.Prober.ConcurrencySubscription = mergedConfig.ConcurrencySubscription | ||
| concurrencyConfig.Prober.ConcurrencySubscriptionResource = mergedConfig.ConcurrencySubscriptionResource | ||
| concurrencyConfig.Prober.Cache = mergedConfig.EnableCaching |
Contributor
There was a problem hiding this comment.
Can we keep this PR to just the concurrency settings and remove the cache flag support?
This isn't the only code that would have to change to enable caching and it's a bit convoluted to support properly. I can see resource graph response caching being valuable but the metric cache feels unnecessary unless you have misconfiguration alloy to scrape more often than the timespan config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Notes to the Reviewer
PR Checklist