[wip] fix node_exporter version #5041
Draft
+65
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cursor Agent can help with this pull request. Just |
…rter version The prometheus.exporter.unix component was registering a node_exporter_build_info metric that incorrectly showed Alloy's version information instead of the actual node_exporter version (v1.9.1). This fix: - Adds a custom buildInfoCollector that exposes the correct node_exporter version - Uses the version from the github.com/prometheus/node_exporter dependency (v1.9.1) - Includes the revision from the grafana/node_exporter fork being used - Adds a test to verify the metric contains the correct version Fixes #4330
cursor
bot
force-pushed
the
cursor/debug-grafana-alloy-issue-2bcb
branch
from
353cad1 to
473edfe
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Removes the misleading
node_exporter_build_infometric from theprometheus.exporter.unixcomponent.Previously, this metric reported Alloy's build version (e.g., v1.10.2) instead of the underlying node_exporter's version, as it was generated using Alloy's
build.NewCollector(). This fix ensures that the component does not expose incorrect build information.Which issue(s) this PR fixes
Fixes #4330
Notes to the Reviewer
The upstream
node_exporterlibrary (v1.9.1, as used by Alloy) does not expose anode_exporter_build_infometric. Removing this incorrect metric aligns with upstream behavior and prevents confusion about the version reported.PR Checklist
Slack Thread