proposal: Picking a Prometheus WAL #5048
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptodev
reviewed
Dec 11, 2025
|
|
||
| This is not a viable options and accomplishes none of the goals. | ||
|
|
||
| ## Proposal 1: Improve remote_write to be the WAL we need |
Contributor
There was a problem hiding this comment.
It'd be good to make it more clear what the accepted solution is. One way to do it is if Proposal 1 becomes the entire "Proposal" section, and the rest could be listed in "Alternative Solutions" similarly to an earlier doc.
Contributor
Author
There was a problem hiding this comment.
Yeah I guess I was more trying to directly translate our internal design doc process here. We do have two very valid proposals and based the discussion I would want to add a "conclusion" to have the PR merged. I can see the suggested format being useful when there's a single viable option but otherwise it feels a bit "leading" to present what is likely the authors choice as the "Proposal" and everything else as "Alternates".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add proposal to decide our path forward with our two prometheus WAL implementations.
Which issue(s) this PR fixes
Related to: #5039