Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR switches labelstore to use a RWMutex with a RLock for
labelstore.GetLocalLink. I tried to add some concurrency test to show proof of impact but locally I can't seem to get enough concurrency or this doesn't help so I'll do some testing internally in draft. Full breakdown of rational in Notes to the ReviewerWhich issue(s) this PR fixes
Related to:
Notes to the Reviewer
With very high append concurrency we have hit scrape timeouts which correlate with high mutex contention.
The mutex contention is largely driven by

labelstore.GetLocalLinkwhich is called on every single append call. During the time period above that function was responsible for over 50% of our mutex wait,Since it's a pure read operation switching to RWLock with RLock should help.
PR Checklist