fix: Change service stop command from 'sc' to 'net'#5906
Merged
x1unix merged 3 commits intografana:mainfrom Apr 1, 2026
Merged
fix: Change service stop command from 'sc' to 'net'#5906x1unix merged 3 commits intografana:mainfrom
x1unix merged 3 commits intografana:mainfrom
Conversation
|
|
|
|
mateuszdrab
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Windows NSIS installer/uninstaller to stop the Alloy Windows service using net stop (which waits for service termination) instead of sc stop, aiming to make upgrades more reliable.
Changes:
- Replace
sc stop "Alloy"withnet stop "Alloy"in the install section. - Replace
sc stop "Alloy"withnet stop "Alloy"in the uninstall section.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mateuszdrab
force-pushed
the
fix-windows-service-stop
branch
from
8762754 to
50c00de
Compare
Contributor
Author
|
Applied feedback from automated review and rebased |
gaantunes
pushed a commit
that referenced
this pull request
Apr 3, 2026
<!-- CONTRIBUTORS GUIDE: https://github.com/grafana/alloy/blob/main/docs/developer/contributing.md If this is your first PR or you have not contributed in a while, we recommend taking the time to review the guide. **NOTE** Your PR title must adhere to Conventional Commit style. For details on this, check out the Contributors Guide linked above. --> ### Brief description of Pull Request Switches service stop command from sc stop to net stop which waits for service termination. ### Pull Request Details <!-- Detailed descripion of the Pull Request, if needed. --> ### Issue(s) fixed by this Pull Request #3605 ### Notes to the Reviewer <!-- Relevant notes for reviewers/testers. --> ### PR Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] Documentation added - [ ] Tests updated - [ ] Config converters updated --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
Switches service stop command from sc stop to net stop which waits for service termination.
Pull Request Details
Issue(s) fixed by this Pull Request
#3605
Notes to the Reviewer
PR Checklist