feat(loki.secretfilter): Remove redundant secrets_redacted_by_rule_total and secrets_redacted_by_origin metrics#5970
Merged
kleimkuhler merged 5 commits intomainfrom Apr 7, 2026
Conversation
Contributor
|
💻 Deploy preview deleted (feat(loki.secretfilter): Remove redundant |
…ter-remove-metrics
mikefat
reviewed
Apr 2, 2026
Contributor
mikefat
left a comment
mikefat
left a comment
There was a problem hiding this comment.
LGTM just minor comment on the docs formatting
kalleep
approved these changes
Apr 7, 2026
mikefat
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
The
loki_secretfilter_secrets_redacted_by_category_totalmetric (introduced in #5855) partitions by bothruleandorigin, making the two single-dimension metrics redundant. Any query with them can be expressed viasum by (rule|origin) (...)on the category metric.This change removes those metrics now that they are no longer needed.
Issue(s) fixed by this Pull Request
Redundant metrics lead to high cardinality and complicate secretfilter.
PR Checklist