Skip to content

Conversation

@marctc
Copy link
Contributor

@marctc marctc commented Mar 11, 2025

Previous implementation was using Add and Sub for traces_target_info.
This is risky because in some cases, it can lead to negative values.

Fixes #1707

@marctc marctc requested a review from a team as a code owner March 11, 2025 15:13
@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.01%. Comparing base (52143b0) to head (d06e090).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/export/prom/prom.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1735      +/-   ##
==========================================
+ Coverage   66.95%   67.01%   +0.05%     
==========================================
  Files         214      214              
  Lines       22225    22225              
==========================================
+ Hits        14880    14893      +13     
+ Misses       6607     6598       -9     
+ Partials      738      734       -4     
Flag Coverage Δ
integration-test 54.21% <50.00%> (+0.09%) ⬆️
k8s-integration-test 53.86% <50.00%> (-0.02%) ⬇️
oats-test 34.86% <0.00%> (+0.11%) ⬆️
unittests 43.87% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marevers marevers self-requested a review March 12, 2025 07:34
@marctc marctc merged commit 5f4c3ae into main Mar 12, 2025
13 checks passed
@marctc marctc deleted the fix_target_info_bug branch March 12, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

traces_target_info is inconsistent and confusing

3 participants