Skip to content

Conversation

@mariomac
Copy link
Contributor

ProtoDebug=true shows messages in binary format, which are useful for binary buffers but not really for printable text.

Replacing %v by %q so it will show printable characters as text, and non-printable characters as escaped char codes.

Example: https://go.dev/play/p/GVXC3OIu5q9?v=

@mariomac mariomac requested a review from a team as a code owner March 12, 2025 12:05
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.98%. Comparing base (6a9c97d) to head (947a76e).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/internal/ebpf/common/tcp_detect_transform.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1738   +/-   ##
=======================================
  Coverage   66.98%   66.98%           
=======================================
  Files         214      214           
  Lines       22225    22225           
=======================================
+ Hits        14887    14888    +1     
  Misses       6602     6602           
+ Partials      736      735    -1     
Flag Coverage Δ
integration-test 54.10% <0.00%> (-0.22%) ⬇️
k8s-integration-test 53.89% <0.00%> (+0.03%) ⬆️
oats-test 34.75% <0.00%> (ø)
unittests 43.87% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mariomac mariomac merged commit 6e7397a into grafana:main Mar 12, 2025
13 checks passed
marctc added a commit that referenced this pull request Apr 16, 2025
marctc added a commit that referenced this pull request Apr 17, 2025
@mariomac mariomac deleted the proto-debug branch July 21, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants