test(config): verify feature flags propagation to OBI #2349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelroquetto
approved these changes
Dec 3, 2025
Contributor
rafaelroquetto
left a comment
rafaelroquetto
left a comment
There was a problem hiding this comment.
This is great, thank you so much @apetro2!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2349 +/- ##
=======================================
Coverage 49.78% 49.78%
=======================================
Files 38 38
Lines 2971 2971
=======================================
Hits 1479 1479
Misses 1343 1343
Partials 149 149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
mariomac
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a
TODOinpkg/beyla/config_test.goby comprehensively verifying the propagation of various configuration typ during Beyla-to-OBI conversion.The added assertions cover:
NetworkFlows.Enable,Attributes.Kubernetes.EnableServiceNameAttributes.InstanceID.OverrideThis ensures that critical configuration parameters—regardless of type or nesting level—are correctly mapped and not silently lost or reset to defaults.