Closed
Conversation
bossinc
reviewed
Oct 28, 2025
Comment on lines
+200
to
+207
| {/* <Switch | ||
| value={builderState.liveView} | ||
| onChange={onOptionChange('liveView')} | ||
| label={labels.liveView.label} | ||
| tooltip={labels.liveView.tooltip} | ||
| inline | ||
| /> */} | ||
| </div> |
bossinc
reviewed
Oct 28, 2025
| </InlineFormLabel> | ||
| <Input | ||
| width={200} | ||
| // width={200} |
bossinc
reviewed
Oct 28, 2025
| /> | ||
| </div> | ||
| <div className="gf-form"> | ||
| <div> |
Collaborator
There was a problem hiding this comment.
are we able to remove the divs without styling in this file?
bossinc
reviewed
Oct 28, 2025
Comment on lines
+205
to
+208
| // REMOVE this whole method | ||
| // getDataProvider(type: SupplementaryQueryType, request: DataQueryRequest<CHQuery>): Observable<DataQueryResponse> | undefined { ... } | ||
|
|
||
| // ADD this instead: |
Collaborator
There was a problem hiding this comment.
but we didnt remove a function called getDataProvider right?
Do we need to keep this comment even if we did?
bossinc
reviewed
Oct 28, 2025
| const key = escapeKey(f.key); | ||
| const value = escapeValueBasedOnOperator(f.value, f.operator); | ||
| const condition = i !== adHocFilters.length - 1 ? (f.condition ? f.condition : 'AND') : ''; | ||
| const condition = i !== adHocFilters.length - 1 ? 'AND' : ''; |
Collaborator
There was a problem hiding this comment.
Won't this always make adHocFileters AND so you will never be able to use OR
bossinc
reviewed
Oct 28, 2025
| values: field.values, | ||
| const effectiveName = oneLevelDetected && field.name === DEFAULT_LOGS_ALIAS ? 'logs' : field.name; | ||
|
|
||
| const logLevel = LogLevel[effectiveName as keyof typeof LogLevel] ?? LogLevel.unknown; |
Collaborator
There was a problem hiding this comment.
Changing this to ?? changes the behavor. Is this what we want?
bossinc
reviewed
Oct 28, 2025
| validateSql: { | ||
| label: 'Validate SQL', | ||
| tooltip: 'Validate SQL in the editor.', | ||
| tooltip: 'Validate SQL in the editor', |
Collaborator
There was a problem hiding this comment.
I believe tool tips that are sentences have periods at the end.
github-project-automation
Bot
moved this from In Progress
to Done
in Partner Datasources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes deprecated code, components and styles.
Code
toBeCalledTimesis deprecated; replaced withtoHaveBeenCalledTimestoBeCalledWithis deprecated; replaced withtoHaveBeenCalledWithlightThemeis deprecated; replaced withthemeerroris deprecated; replaced witherrorsMutableDataFrameis deprecated; replaced withDataFramegetDataProvideris deprecated; replaced withgetSupplementaryQueryRequestconditionis deprecatedComponents
HorizontalGroupandVerticalGroupare deprecated; replaced withStackStyles
gf-formstylesNOTE:
Selectcomponent is deprecated and should be replaced withCombobox. This work is not included in this PR due to testing issues with Combobox.