Skip to content

Allow $__adhocFilters macro to work with multiple tables#1631

Closed
mbUSC wants to merge 11 commits intografana:mainfrom
mbUSC:main
Closed

Allow $__adhocFilters macro to work with multiple tables#1631
mbUSC wants to merge 11 commits intografana:mainfrom
mbUSC:main

Conversation

@mbUSC
Copy link
Copy Markdown

@mbUSC mbUSC commented Feb 13, 2026

Type of Change

Please check the relevant option.

  • 🚀 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧹 Refactor / Chore

Feature

What is this feature?

This feature is an enhancement to #1488 that allows users to specify multiple tables in $__adhocFilters.

Why is this feature needed?

$__adhocFilters currently does not work with multiple tables.

Who is this feature for?

Users with complex queries, CTEs, etc.

How to test this feature

npm run test:ci


Please check that:

  • Tests for this change have been added/updated.
  • Documentation has been added/updated (where applicable).

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 13, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ bossinc
❌ mbUSC


mbUSC seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@adamyeats adamyeats moved this from Incoming to Needs Review in Partner Datasources Feb 18, 2026
@bossinc bossinc self-assigned this Feb 20, 2026
Copy link
Copy Markdown
Collaborator

@bossinc bossinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the addition

@bossinc bossinc enabled auto-merge (squash) February 24, 2026 03:57
@bossinc
Copy link
Copy Markdown
Collaborator

bossinc commented Feb 25, 2026

@mbUSC would you mind accepting the cla please? 😃

@mbUSC
Copy link
Copy Markdown
Author

mbUSC commented Feb 26, 2026

I accepted it when I made the PR, looks like it hasn't synced. Probably an issue with the bot
image

@bossinc
Copy link
Copy Markdown
Collaborator

bossinc commented Mar 11, 2026

@mbUSC 👋 I know this is annoying but could you accept the cla one more time? I think the bot is getting stuck.

@bossinc
Copy link
Copy Markdown
Collaborator

bossinc commented Mar 12, 2026

@mbUSC We found the issue! The email you use to sign the CLA must match the email on the commits. One of the commits has the author's email as a@b.c. ( commit eb74401) This commit needs to be dropped, modified, or squashed so that the email used to sign the CLA matches all the commit author emails.

@bossinc bossinc moved this from Needs Review to Waiting in Partner Datasources Mar 12, 2026
@mbUSC
Copy link
Copy Markdown
Author

mbUSC commented Apr 1, 2026

Closing this PR as unmergeable because of the CLA bot issue.
New PR: #1757

@mbUSC mbUSC closed this Apr 1, 2026
auto-merge was automatically disabled April 1, 2026 06:08

Pull request was closed

@github-project-automation github-project-automation bot moved this from Waiting to Done in Partner Datasources Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants