Open
Conversation
2f1cb40 to
0204b42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after: grafana/grafana#122302
Adds inline field validation to the ClickHouse v2 config editor behind the
clickHouseConfigValidationfeature toggle. When enabled, the following fields are validated on save and display inline errors:ServerAndEncryptionSection)ServerAndEncryptionSection)DatabaseCredentialsSection)When validation fails, Grafana's native datasource testing status banner surfaces the errors — no save reaches the backend until all required fields are filled.
Without this, an empty host/port would reach the ClickHouse backend and return a generic connection error. Inline errors give users immediate, field-level feedback before any network request is made.
Notes
clickHouseConfigValidation= true andnewClickhouseConfigPageDesign= trueclickHouseConfigValidation = false(default), behaviour is unchanged —validationisundefined, no validators register, save proceeds as before.newClickhouseConfigPageDesign = true).DataSourceConfigValidationAPIintoEditDataSourceand passes thevalidationprop to plugin config editors.