Skip to content

fix(aws): skip failing RDS and VPC collectors instead of aborting provider #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephan-rayner wants to merge 1 commit into from
+8 −2
Closed

fix(aws): skip failing RDS and VPC collectors instead of aborting provider #863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pkg/aws/aws.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,10 @@ func newWithDependencies(ctx context.Context, config *Config, awsClient client.C
// as for RDS , the pricing data is only available in the us-east-1
pricingConfig, err := createAWSConfig(ctx, "us-east-1", config.Profile, config.RoleARN)
if err != nil {
return nil, err
logger.LogAttrs(ctx, slog.LevelError, "Error creating collector",
slog.String("service", service),
slog.String("message", err.Error()))
continue
}
awsRDSClient := client.NewAWSClient(client.Config{
PricingService: awsPricing.NewFromConfig(pricingConfig),
Expand Down Expand Up @@ -199,7 +202,10 @@ func newWithDependencies(ctx context.Context, config *Config, awsClient client.C
// as for VPC, the pricing data is only available in the us-east-1
pricingConfig, err := createAWSConfig(ctx, "us-east-1", config.Profile, config.RoleARN)
if err != nil {
return nil, err
logger.LogAttrs(ctx, slog.LevelError, "Error creating collector",
slog.String("service", service),
slog.String("message", err.Error()))
continue
}
awsVPCClient := client.NewAWSClient(client.Config{
PricingService: awsPricing.NewFromConfig(pricingConfig),
Expand Down
Loading