Skip to content

Cue: Detect references with unifications #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spinillos merged 4 commits into from
Apr 9, 2026
+7 −1
Merged

Cue: Detect references with unifications #1065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ae1293
Fix cue imports when we use the client
spinillos Apr 1, 2026
652b092
Merge branch 'main' of github.com:grafana/cog
spinillos Apr 7, 2026
56ab9c5
Identify references unified with topkind
spinillos Apr 8, 2026
b66331a
remove unused import
spinillos Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion internal/jennies/golang/templates/types/disjunction_of_refs.json_unmarshal.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{{- $json := importStdPkg "encoding/json" -}}
{{- $errors := importStdPkg "errors" -}}
{{- $struct := .def.Type.Struct -}}
// UnmarshalJSON implements a custom JSON unmarshalling logic to decode `{{ .def.Name|formatObjectName }}` from JSON.
func (resource *{{ .def.Name|formatObjectName }}) UnmarshalJSON(raw []byte) error {
Expand Down
7 changes: 7 additions & 0 deletions internal/simplecue/generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,13 @@ func getReference(v cue.Value) (bool, cue.Value, cue.Value) {
if op == cue.AndOp && exprs[0].Subsume(exprs[1]) == nil && exprs[1].Subsume(exprs[0]) == nil {
return true, exprs[0], exprs[1]
}

// We could have a reference unified with a cue.TopKind (_). We can assume that if we have an existing path unified with this
// it's a valid reference.
if path.String() != "" && exprs[1].IncompleteKind() == cue.TopKind {
return true, exprs[0], exprs[0]
}

return false, v, v
}

Expand Down
Loading