Skip to content

Cue: Enums with defaults generating wrong types #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spinillos wants to merge 2 commits into
base: main
Choose a base branch
from
+443 −4
Open

Cue: Enums with defaults generating wrong types #1069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4155b7c
Detect constant references properly when they contains defaults
spinillos Apr 10, 2026
95e98ba
Tests
spinillos Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions internal/simplecue/generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,13 +518,20 @@ func (g *generator) declareReference(v cue.Value, defV cue.Value) (ast.Type, err
}
}

if v.Kind() == cue.StringKind || v.Kind() == cue.NumberKind {
// concreteV is v if v is a concrete string/number (e.g. #Enum1 & "A" when "A" is not the default),
// or defV when v is abstract but defV is a concrete constraint (e.g. #Enum2 & "C" where "C" is the
// default of #Enum2 — CUE's subsumption collapses the conjunction so v becomes the abstract reference).
concreteV := v
if concreteV.Kind() != cue.StringKind && concreteV.Kind() != cue.NumberKind {
concreteV = defV
}
if concreteV.Kind() == cue.StringKind || concreteV.Kind() == cue.NumberKind {
var referenceValue any
referenceValue, err = v.String()
referenceValue, err = concreteV.String()
if err != nil {
referenceValue, err = v.Int64()
referenceValue, err = concreteV.Int64()
if err != nil {
return ast.Type{}, errorWithCueRef(v, "%v", err.Error())
return ast.Type{}, errorWithCueRef(concreteV, "%v", err.Error())
}
}

Expand Down
Loading
Loading