Skip to content

Go: Add formatPkg function for custom Go templates #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spinillos wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Go: Add formatPkg function for custom Go templates #828

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14c23b6
Add formatPkg function for custom Go templates
spinillos Jul 14, 2025
fd0fc0d
Using the proper function name to add packages
spinillos Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions internal/jennies/golang/rawtypes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,11 @@ func (jenny RawTypes) generateSchema(context languages.Context, schema *ast.Sche

customMethodsBlock := template.CustomObjectMethodsBlock(object)
if jenny.tmpl.Exists(customMethodsBlock) {
innerErr = jenny.tmpl.RenderInBuffer(&buffer, customMethodsBlock, map[string]any{
innerErr = jenny.tmpl.Funcs(map[string]any{
"formatPkg": func(pkg string) string {
Copy link
Copy Markdown
Member

@K-Phoen K-Phoen Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not sticking with existing helper names?
See the builder.go jenny:

cog/internal/jennies/golang/builder.go

Lines 102 to 104 in 08b3544

"importStdPkg": func(pkg string) string {
return imports.Add(pkg, pkg)
},

return imports.Add(pkg, pkg)
},
}).RenderInBuffer(&buffer, customMethodsBlock, map[string]any{
"Object": object,
})
if innerErr != nil {
Expand All @@ -125,7 +129,11 @@ func (jenny RawTypes) generateSchema(context languages.Context, schema *ast.Sche

customSchemaVariant := template.CustomSchemaVariantBlock(schema)
if jenny.tmpl.Exists(customSchemaVariant) {
if err := jenny.tmpl.RenderInBuffer(&buffer, customSchemaVariant, map[string]any{
if err := jenny.tmpl.Funcs(map[string]any{
"formatPkg": func(pkg string) string {
return imports.Add(pkg, pkg)
},
}).RenderInBuffer(&buffer, customSchemaVariant, map[string]any{
"Schema": schema,
"Config": jenny.config,
}); err != nil {
Expand Down
Loading