fix(deps): update dependency com.android.tools.build:gradle to v9#125
fix(deps): update dependency com.android.tools.build:gradle to v9#125renovate-sh-app[bot] wants to merge 1 commit intomainfrom
Conversation
57538a3 to
0d9d963
Compare
android/build.gradle
Outdated
|
|
||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:8.13.2' | ||
| classpath 'com.android.tools.build:gradle:9.0.0' |
There was a problem hiding this comment.
AGP 9.0 requires Gradle 9.x but using 8.14.3
High Severity
The Android Gradle Plugin is upgraded from 8.13.2 to 9.0.0, but the Gradle wrapper version in gradle-wrapper.properties remains at 8.14.3. AGP 9.x requires Gradle 9.x to function. This version mismatch will cause the build to fail at configuration time with an incompatibility error. The Gradle wrapper version needs to be updated to 9.x alongside this AGP upgrade.
android/build.gradle
Outdated
|
|
||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:8.13.2' | ||
| classpath 'com.android.tools.build:gradle:9.0.0' |
There was a problem hiding this comment.
Example app AGP version not updated causing mismatch
Medium Severity
The library's AGP version is updated to 9.0.0, but example/android/settings.gradle still declares "com.android.application" version "8.13.2". This creates a major version mismatch between the library (AGP 9.x) and the example app (AGP 8.x). When building the example app that depends on this library, the version inconsistency across modules could cause build failures or unexpected behavior.
|
Bugbot Autofix prepared a fix for 2 of the 2 bugs found in the latest run.
Or push these changes by commenting: Preview (59b8779658)diff --git a/android/gradle/wrapper/gradle-wrapper.properties b/android/gradle/wrapper/gradle-wrapper.properties
--- a/android/gradle/wrapper/gradle-wrapper.properties
+++ b/android/gradle/wrapper/gradle-wrapper.properties
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-9.0-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
diff --git a/example/android/gradle/wrapper/gradle-wrapper.properties b/example/android/gradle/wrapper/gradle-wrapper.properties
--- a/example/android/gradle/wrapper/gradle-wrapper.properties
+++ b/example/android/gradle/wrapper/gradle-wrapper.properties
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-9.0-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
diff --git a/example/android/settings.gradle b/example/android/settings.gradle
--- a/example/android/settings.gradle
+++ b/example/android/settings.gradle
@@ -18,7 +18,7 @@ pluginManagement {
plugins {
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
- id "com.android.application" version "8.13.2" apply false
+ id "com.android.application" version "9.0.0" apply false
id "org.jetbrains.kotlin.android" version "2.3.0" apply false
} |
f77dd8f to
c047766
Compare
39b21cd to
6990027
Compare
6990027 to
2ceae7d
Compare
2ceae7d to
5c2742a
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: AGP 9.0 removed
enableJetifierflag still in properties- Removed the obsolete
android.enableJetifierproperty fromandroid/gradle.propertiesto align with AGP 9.0+ requirements.
- Removed the obsolete
Or push these changes by commenting:
@cursor push 0df4873d0e
Preview (0df4873d0e)
diff --git a/android/gradle.properties b/android/gradle.properties
--- a/android/gradle.properties
+++ b/android/gradle.properties
@@ -11,6 +11,5 @@
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
# org.gradle.parallel=true
#Fri Dec 29 13:26:00 IST 2023
-android.enableJetifier=true
android.useAndroidX=true
org.gradle.jvmargs=-Xmx4096M
android/build.gradle
Outdated
|
|
||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:8.13.2' | ||
| classpath 'com.android.tools.build:gradle:9.0.1' |
There was a problem hiding this comment.
AGP 9.0 removed enableJetifier flag still in properties
Medium Severity
Upgrading to AGP 9.0.1 makes the android.enableJetifier=true setting in android/gradle.properties invalid — AGP 9.0 removed support for this property. This will cause a build failure or error at configuration time, separate from the Gradle wrapper version issue. The flag needs to be removed from gradle.properties as part of this migration.
369af23 to
24fffbf
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Removed
compileSdkVersion/minSdkVersionDSL methods break build- Updated
android/build.gradleto use AGP 9-compatiblecompileSdk 35andminSdk 19syntax, replacing removed legacy DSL methods.
- Updated
Or push these changes by commenting:
@cursor push a0bf92e07a
Preview (a0bf92e07a)
diff --git a/android/build.gradle b/android/build.gradle
--- a/android/build.gradle
+++ b/android/build.gradle
@@ -22,7 +22,7 @@
apply plugin: 'com.android.library'
android {
- compileSdkVersion 35
+ compileSdk 35
compileOptions {
sourceCompatibility JavaVersion.VERSION_17
@@ -30,7 +30,7 @@
}
defaultConfig {
- minSdkVersion 19
+ minSdk 19
}
namespace 'com.grafana.faro'
android/build.gradle
Outdated
|
|
||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:8.13.2' | ||
| classpath 'com.android.tools.build:gradle:9.0.1' |
There was a problem hiding this comment.
Removed compileSdkVersion/minSdkVersion DSL methods break build
High Severity
AGP 9.0 removes the old compileSdkVersion and minSdkVersion DSL methods when the new DSL is enabled by default. The existing build.gradle uses compileSdkVersion 35 and minSdkVersion 19, which will cause build errors with AGP 9.0.1. These need to be updated to the new compileSdk and minSdk syntax as part of the migration.
a1fee79 to
5200be2
Compare
| datasource | package | from | to | | ---------- | ------------------------------ | ------ | ----- | | maven | com.android.tools.build:gradle | 8.13.2 | 9.1.0 | Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
5200be2 to
99186a4
Compare
|
Closing: Bumping AGP to v9 in the SDK's android/build.gradle would force all consumers to also use AGP 9 and Gradle 9. Deferring until the Flutter/Android ecosystem has broader adoption. |
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> ## Description Consolidates compatible Renovate dependency updates into a single PR, prioritizing stability for a published Flutter plugin. This includes updating key plugin dependencies and development tooling while deferring higher-risk upgrades. ## Related Issue(s) Fixes #120, #122, #123, #127, #130, #142 ## Type of Change - [ ] 🛠️ Bug fix (non-breaking change which fixes an issue) - [ ] 🚀 New feature (non-breaking change which adds functionality) - [ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 📝 Documentation - [ ] 📈 Performance improvement - [ ] 🏗️ Code refactoring - [x] 🧹 Chore / Housekeeping ## Checklist - [ ] I have made corresponding changes to the documentation - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the CHANGELOG.md under the "Unreleased" section ## Screenshots (if applicable) ## Additional Notes This PR consolidates several Renovate dependency updates, carefully selecting those compatible with the current Flutter stable toolchain and the constraints of a published plugin. Specifically: * Updated `connectivity_plus` to `7.0.0` * Updated `package_info_plus` to `9.0.0` * Updated repo-only tooling: `flutter_lints` to `6.0.0`, Kotlin plugin to `2.3.10`, Gradle wrapper to `8.14.4`, and `actions/setup-java` to `v5.2.0`. The AGP 9 / app plugin 9 path (related to Renovate PRs #121, #124, #125) has been deferred due to its higher risk for a plugin repo and existing compatibility issues in the example app requiring a further Gradle upgrade (9.3.1) which is not yet needed for the current dependency set. Extensive verification was performed, including `flutter analyze`, `flutter test`, `dart tool/pre_release_check.dart`, and an `flutter build apk` of the example app. --- <p><a href="https://cursor.com/agents/bc-e054265d-c10f-4ee8-8011-617e26b382ab"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-e054265d-c10f-4ee8-8011-617e26b382ab"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </p> <!-- CURSOR_AGENT_PR_BODY_END --> --------- Co-authored-by: Robert Magnusson <robert-northmind@users.noreply.github.com>
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |



This PR contains the following updates:
8.13.2→9.1.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
Need help?
You can ask for more help in the following Slack channel: #proj-renovate-self-hosted. In that channel you can also find ADR and FAQ docs in the Resources section.