feat(ios): Swift Package Manager support and iOS 13 minimum#208
Draft
robert-northmind wants to merge 2 commits intomainfrom
Draft
feat(ios): Swift Package Manager support and iOS 13 minimum#208robert-northmind wants to merge 2 commits intomainfrom
robert-northmind wants to merge 2 commits intomainfrom
Conversation
Add ios/faro/Package.swift with FlutterFramework and PLCrashReporter, relayout Swift sources under ios/faro/Sources/faro/, raise iOS minimum to 13.0, and drop stale vendored CrashReporter.xcframework podspec entries. Bump Dart/Flutter SDK constraints for SPM integration. Fix analyzer issues so flutter analyze exits zero on stable. Co-authored-by: Robert Magnusson <robert-northmind@users.noreply.github.com>
|
|
Run dart format on the repo so `dart format --set-exit-if-changed .` matches stable CI. Document in CHANGELOG. Co-authored-by: Robert Magnusson <robert-northmind@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Swift Package Manager support for the iOS plugin per Flutter’s plugin author guide, while keeping CocoaPods via an updated
faro.podspec.ios/faro/Package.swiftwithFlutterFrameworkand Microsoft PLCrashReporter (CrashReporterproduct).ios/Classes/toios/faro/Sources/faro/(Flutter’s recommended layout).vendored_frameworks/preserve_pathsfor a missingCrashReporter.xcframework; PLCrashReporter remains the CocoaPods dependency.pubspec.yamlenvironmenttosdk: >=3.11.0andflutter: >=3.41.0(required for Flutter SPMFlutterFramework).pubspec.yamlenvironment aligned with the package.ios/.gitignore:.build/and.swiftpm/.avoid_null_checks_in_equality_operatorsand small lint-driven fixes soflutter analyzeexits 0 on current stable (CI uses analyzer exit code).dart formatapplied so CIdart format --set-exit-if-changed .passes on stable.Closes #189 when merged.
Related Issue(s)
Fixes #189
Type of Change
Checklist
AGENTS.mdpath note;CHANGELOG.mdunder Unreleased)flutter testpassed locally; iOS SPM/CocoaPods builds should be verified on macOS (pod lib lint,flutter runwith SPM enabled/disabled)Additional Notes
pod lib lint ios/faro.podspecand an Xcode build withflutter config --enable-swift-package-manager(and with it disabled) — not runnable in this Linux CI agent.