alloy_readiness_check_use_https

[piotr-g]

Configure protocol schema of the ready endpoint

[CLAassistant]

All committers have signed the CLA.

[voidquark]

Can you also add the variable to the README and explain that it only enables validation for https, since the actual TLS configuration must be provided in the main configuration file itself?

[voidquark]

@piotr-g

I was considering the variable name, but ansible_server_tls_enabled could be misleading for some users. In reality, this variable does not enable TLS in Alloy. It only affects how the readiness check is performed.

That's why I prefer a name that clearly reflects its actual purpose: alloy_readiness_check_use_https.

For the README, I have also suggestion:
This boolean variable determines whether the readiness check for the Alloy server should use HTTPS or HTTP when validating the /-/ready endpoint. This variable does not enable TLS on the Alloy server itself.

Once this is in place, I think we're good to merge 🚀

[piotr-g]

@piotr-g

I was considering the variable name, but ansible_server_tls_enabled could be misleading for some users. In reality, this variable does not enable TLS in Alloy. It only affects how the readiness check is performed.

That's why I prefer a name that clearly reflects its actual purpose: alloy_readiness_check_use_https.

For the README, I have also suggestion: This boolean variable determines whether the readiness check for the Alloy server should use HTTPS or HTTP when validating the /-/ready endpoint. This variable does not enable TLS on the Alloy server itself.

Once this is in place, I think we're good to merge 🚀

You're right I just used the same variable to enable the server. Besides that the check will fail if the var is set to true and tls is not configured for the internal server like that:

{% if alloy_server_tls_enabled %}
http {
  tls {
    cert_file = "/etc/ssl/certs/{{ ansible_hostname }}-chain.pem"
    key_file  = "/etc/ssl/private/{{ ansible_hostname }}.key"
  }
}
{% endif %}

I'm going to change the var name and add suggested comment.

[voidquark]

Looks good now. Thanks for your contribution 🚀