[codegen] Convert all jennies to use codegen.AppManifest

[IfSentient]

What Changed? Why?

This PR converts all jennies still using codegen.Kind over to using codegen.AppManifest, and deprecates codegen.Kind. Currently, as we continue to add jennies, they have to end up in generators that are using codegen.AppManifest, and don't always fit in that space (see the go client jenny as an example, which is in the manifest generator instead of the resource one that generates all other gotype code). This change allows us to more intelligently group jennies in the future, and move the codegen model over entirely to be AppManifest-based.

How was it tested?

Codegen tests to ensure output didn't change, and created and built a new project to make sure the project codegen was still accurate.

Where did you document your changes?

N/A - no user-facing changes.

Notes to Reviewers

[IfSentient]

Drive-by that I noticed when doing new project testing--this was four spaces instead of a tab.

[amalavet]

this is somewhat similar to the logic for getting the tmd.Resources from the manifest that you did in app generator. Can we extract this logic and potentially pass the props to the Generate func, or create a helper func that does this? That way we only do one pass through the kinds. It does seem that there are some minute differences that could make this tricky, but just an idea.

[IfSentient]

The KindProperties stuff should probably also be overhauled in the future--for now I didn't want to change the templates in this PR.

[amalavet]

just an idea, but could we create an func that returns an iterator to reduce this nested loop, which you use a lot throughout this PR i.e.

Suggested change

	for _, version := range appManifest.Versions() {
	for _, kind := range version.Kinds() {
	for version, kind := range ManifestKindVersions(appManifest))) {

func ManifestKindVersions(m AppManifest) iter.Seq2[Version, VersionedKind] {
	return func(yield func(Version, VersionedKind) bool) {
		for _, version := range m.Versions() {
			for _, kind := range version.Kinds() {
				if !yield(version, kind) {
					return
				}
			}
		}
	}
}

[IfSentient]

Added codegen.VersionedKinds and codegen.PreferredVersionKinds using iter.Seq2. Good suggestion, I keep forgetting about the iterator stuff that go introduced, and this is a great place to use it.

[amalavet]

nit; maybe you could use a helper func for this scope check?

[amalavet]

Why can you just remove this?

[IfSentient]

Resources isn't used in the template, I forgot to remove it from the metadata as well, let me fix that.

[amalavet]

nit; just a little cleaner to follow

Suggested change

	files = append(files, codejen.File{
	RelativePath: filepath.Join(GetGeneratedGoTypePath(r.GroupByKind, appManifest.Properties().Group, version.Name(), kind.MachineName), fmt.Sprintf("%s_object_gen.go", strings.ToLower(kind.MachineName))),
	Data: b,
	From: []codejen.NamedJenny{r},
	})
	typePath := GetGeneratedGoTypePath(r.GroupByKind, appManifest.Properties().Group, version.Name(), kind.MachineName)
	suffix := fmt.Sprintf("%s_object_gen.go", strings.ToLower(kind.MachineName))
	files = append(files, codejen.File{
	RelativePath: filepath.Join(typePath, suffix),
	Data: b,
	From: []codejen.NamedJenny{r},
	})

[amalavet]

This is still being used in some places, any reason why not removing it across the repo?

[IfSentient]

The only place left that still uses it AFAICT are the parsers, which are exported. I'll deprecate the KindParser, but given that it's an exported type, I want ot leave it present and deprecated for a few releases just in case anyone is using it.