Fix resource.CopyObject and resource.CopyObjectInto zeroing time.Time

health/observer.go

@@ -32,7 +32,7 @@ func (c CheckStatus) String() string {
 	b := strings.Builder{}
 
 	for _, result := range c.Results {
-		b.WriteString(fmt.Sprintf("%s\n", result.String()))
+		b.WriteString(fmt.Sprintf("%s\n", result.String())) //nolint:revive
 	}
 	return b.String()
 }

resource/object.go

@@ -218,8 +218,9 @@ func CopyObjectInto[T any](out T, in T) error {
 }
 
 var errCannotSetValue = errors.New("cannot set value")
+var reflectTypeTime = reflect.TypeOf(time.Time{})
 
-// nolint:gocognit,gocritic
+// nolint:gocognit,gocritic,funlen
 func copyReflectValueInto(dst reflect.Value, src reflect.Value) error {
 	// Check if we can set the value (Set panics if this is false)
 	if !dst.CanSet() {
@@ -239,6 +240,10 @@ func copyReflectValueInto(dst reflect.Value, src reflect.Value) error {
 		typ := src.Type().Elem()
 		switch src.Type().Elem().Kind() {
 		case reflect.Struct:
+			if src.Type() == reflectTypeTime {
+				dst.Set(src)
+				return nil
+			}
 			dstPtr := reflect.New(typ).Interface()
 			err := CopyObjectInto(dstPtr, src.Interface())
 			if err != nil {
@@ -259,6 +264,11 @@ func copyReflectValueInto(dst reflect.Value, src reflect.Value) error {
 			dst.Set(src)
 		}
 	case reflect.Struct:
+		// Special case for time.Time:
+		if src.Type() == reflectTypeTime {
+			dst.Set(src)
+			return nil
+		}
 		// Recursively copy the struct
 		dstStruct := reflect.New(dst.Type()).Interface()
 		err := CopyObjectInto(dstStruct, src.Interface())

resource/object_test.go

@@ -3,6 +3,7 @@ package resource
 import (
 	"errors"
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/assert"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -17,6 +18,7 @@ type ComplexTestObject struct {
 	IntPointer   *int
 	SlicePointer *[]int          // Weird, but valid, types
 	MapPointer   *map[string]int // Weird, but valid, types
+	Timestamp    time.Time       // Times won't be copied right if you try to copy them as a struct (they'll become 0)
 }
 
 type ComplexTestObjectChild struct {
@@ -119,6 +121,7 @@ func TestCopyObjectInto(t *testing.T) {
 			IntPointer:   &i,
 			SlicePointer: &si,
 			MapPointer:   &mi,
+			Timestamp:    time.Now(),
 		},
 		out: &ComplexTestObject{},
 	}}