Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newlines in comments #148

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix newlines in comments #148

wants to merge 3 commits into from

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Mar 6, 2025

The current behavior produces output like:

gh pr view 101684 --json body --template 'Backport beb884292e6f1828f59ca718651821c623c33155 from #101684{{ "\\n\\n---\\n\\n" }}{{ index . "body" }}'

Backport beb884292e6f1828f59ca718651821c623c33155 from #101684\n\n---\n\nAdded to links but not front matter in https://github.com/grafana/grafana/pull/95884/files

Removing one of the backslashes produces:

gh pr view 101684 --json body --template 'Backport beb884292e6f1828f59ca718651821c623c33155 from #101684{{ "\n\n---\n\n" }}{{ index . "body" }}'

Backport beb884292e6f1828f59ca718651821c623c33155 from #101684

---

Added to links but not front matter in https://github.com/grafana/grafana/pull/95884/files

The current behavior produces output like:

```console
gh pr view 101684 --json body --template 'Backport beb884292e6f1828f59ca718651821c623c33155 from #101684{{ "\\n\\n---\\n\\n" }}{{ index . "body" }}'

Backport beb884292e6f1828f59ca718651821c623c33155 from #101684\n\n---\n\nAdded to links but not front matter in https://github.com/grafana/grafana/pull/95884/files
```

Removing one of the backslashes produces:

```console
gh pr view 101684 --json body --template 'Backport beb884292e6f1828f59ca718651821c623c33155 from #101684{{ "\n\n---\n\n" }}{{ index . "body" }}'

Backport beb884292e6f1828f59ca718651821c623c33155 from #101684

---

Added to links but not front matter in https://github.com/grafana/grafana/pull/95884/files
```
@jdbaldry jdbaldry requested a review from a team as a code owner March 6, 2025 13:25
Signed-off-by: Jack Baldry <[email protected]>
@jdbaldry
Copy link
Member Author

jdbaldry commented Mar 7, 2025

Fixed the test, feel free to merge at your convenience :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants