Support chromium args that have comma in it. #631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is bluntly splitting the environment variable by comma for
RENDERING_ARGS
which can fail if we want to pass an argument with a comma in it, which as a result will cause the chromium to crash on run.With this PR, I have added support to consider
\n
instead, so in case if the argument itself contains a comma, the user will have the ability to use\n
as a separator instead of,
in his deployment config.At that time the splitting will work fine, and chromium will accept the arguments without crashing. This is backward compatible and will work only if
\n
is used in the environment variables as shown belowRegards ✨