Add generic backend pagination support for GraphQL cursors#1714
Draft
yesoreyeram wants to merge 6 commits into
Draft
Add generic backend pagination support for GraphQL cursors#1714yesoreyeram wants to merge 6 commits into
yesoreyeram wants to merge 6 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub GraphQL cursor pagination was failing in real usage, and pagination handling was effectively limited to narrower backend query paths. This change makes pagination support generic across backend URL query types while fixing cursor-specific behavior needed for GraphQL providers.
What changed
backendandjq-backend.${__pagination.cursor}withnull.hasNextPage=falsewhen available withendCursorpath.remote.gofor non-obvious pagination behavior and test descriptions inpagination_test.go.Tests
go test ./pkg/...go test ./pkg/infinity ./pkg/modelsyarn test:ci src/editors/query/infinityQuery.test.tsxpkg/infinity/remote_test.gopkg/infinity/pagination_test.gopkg/models/query_test.gosrc/editors/query/infinityQuery.test.tsxNotes for reviewers
The key review surface is
pkg/infinity/remote.gocursor flow, especially first-page replace handling and stop conditions using bothendCursorandhasNextPagesemantics.