tests: add end-to-end testing using Playwright #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
sd2k
commented
Jun 5, 2025
Contributor
Author
|
Hm screenshots show no MCP tools, will have a look at that tomorrow |
|
❌ E2E Tests failure Configuration:
Action Required: |
This commit adds an end-to-end testing infrastructure and UI improvements to ensure the MCP functionality works as expected in a real Grafana plugin. To do so, I had to add a page to the plugin which actually uses the MCP server, so there's been a bit of a rewrite of the main plugin page, but before it just showed the models list which wasn't very useful. I followed the [plugin tools docs](https://grafana.com/developers/plugin-tools/e2e-test-a-plugin/migrate-from-grafana-e2e) for migrating from the old e2e tests (not that we had any anyway), so many of the generated files come from that, but there are also some rather verbose files generated by Claude which we might want to remove before merge.
It sometimes has the sidebar, sometimes doesn't, not worth it.
|
|
obetomuniz
approved these changes
Jun 10, 2025
Contributor
obetomuniz
left a comment
obetomuniz
left a comment
There was a problem hiding this comment.
LGTM 
Just added a tiny guide to help MacOS users if they figure out port conflict issues with AirPlay Receiver.
Contributor
Author
|
Thanks beto! We should probably just use a different port heh, l will fix that in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an end-to-end testing infrastructure and UI improvements to ensure the MCP functionality works as expected in a real Grafana plugin.
To do so, I had to add a page to the plugin which actually uses the MCP server, so there's been a bit of a rewrite of the main plugin page, but before it just showed the models list which wasn't very useful.
I followed the plugin tools docs for migrating from the old e2e tests (not that we had any anyway), so many of the generated files come from that, but there are also some rather verbose files generated by Claude which we might want to remove before merge.