Chore: App with scenes fix drill down page title when space is present in room name #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarrs
requested review from
jackw,
wbrowne,
andresmgot and
xnyo
and removed request for
a team
|
|
|
|
nmarrs
force-pushed
the
fix-app-with-scenes-minor-issue
branch
from
2920993 to
33253e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is broken out from #273
Before we were taking raw URI encoded string and presenting it to user making two word room names have a
%20show up as a space. Now we decode the URI so it is human readable.I noticed this while creating this basic demo getting a scenes app up and running in a local Grafana instance.
Before
After
