Make plugin IDs match for datasource-http-backend example
#484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbrowne
requested review from
Ukochka,
andresmgot,
oshirohugo and
s4kh
and removed request for
a team
|
|
briangann
approved these changes
Mar 7, 2025
andresmgot
reviewed
Mar 10, 2025
| "id": "example-httpbackend-datasource", | ||
| "id": "myorg-httpbackend-datasource", |
There was a problem hiding this comment.
sorry, this breaks some of my devs dashboards and other stuff, can we keep the same plugin ID? (I know it's incosistent between examples though).
There was a problem hiding this comment.
We can sure but I was thinking it might be a good idea to make the IDs consistent at some point. Considering this is dev only, I figured breaking changes would be acceptable 🤷
There was a problem hiding this comment.
yeah, not a big deal but it'd be still incosistent, some of them use grafana as the org, others myorg and others example 🤷
There was a problem hiding this comment.
No that's what I meant 🙈 #485
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.