[tempo-distributed] Support initContainers and extraContainers for compactor #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loafoe
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
|
|
loafoe
changed the title
|
@zanhsieh this PR is based on the main branch, we should close it then right ? |
|
@Sheikh-Abubaker |
|
@zanhsieh @Sheikh-Abubaker I've rebased the PR to the latest |
Signed-off-by: Andy Lo-A-Foe <[email protected]>
Signed-off-by: MH <[email protected]> Signed-off-by: MH <[email protected]>
Signed-off-by: MH <[email protected]> Signed-off-by: MH <[email protected]>
zanhsieh
approved these changes
Jan 15, 2025
Sheikh-Abubaker
approved these changes
Jan 15, 2025
| @@ -54,6 +54,8 @@ spec: | |||
| hostAliases: | |||
| {{- toYaml . | nindent 8 }} | |||
| {{- end }} | |||
| initContainers: | |||
| {{- toYaml .Values.ingester.initContainers | nindent 8 }} | |||
There was a problem hiding this comment.
This is a bug.
It should have been
- {{- toYaml .Values.ingester.initContainers | nindent 8 }}
+ {{- toYaml .Values.compactor.initContainers | nindent 8 }}There was a problem hiding this comment.
Will be fixed in this PR: #3552 , thx!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case where we need to run an init container and extra container as part of the compactor pod.