[grafana] Make sidecar containers working #4046
Open
+22
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvainOL
requested review from
QuentinBisson,
Xtigyro,
jkroepke,
maorfr and
torstenwalter
as code owners
|
|
Collaborator
|
@sylvainOL hey it looks like your PR has conflicts. Do you think you could double check the port configuration and fix the conflicts so we can get this merged? |
Author
|
For the port I intentionnally didn't used the default one ( This way, if someone add another kiwigrid sidecar and forget to set a value, it'll works out of the box. |
QuentinBisson
approved these changes
Dec 11, 2025
Collaborator
|
Could you upgrade the chart once last time? Thank you |
sylvainOL
changed the title
If `METHOD` is set to `LIST` and with ` and with `restartPolicy` set to `Always`, the pod starts and stops just after retrieving the files and then is restarted right away. Thus it prevents actual start of Grafana. Signed-off-by: Sylvain Desbureaux <[email protected]>
kiwigrid new containers always start an health server. If several sidecar containers are used, default value is creating collision. Let's use a different default value for all sidecar containers so they can start without hassle. Signed-off-by: Sylvain Desbureaux <[email protected]>
sylvainOL
force-pushed
the
make-sidecar-containers-working
branch
from
7aa4439 to
696eee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use sidecars containers as init containers with
restartPolicyset toAlways(a.k.a. native sidecar), several small issues are occuring:uin its definition (grafana: stray u in init-sc-dashboard startupProbe #4033)METHODis hardcoded for alerts and notifier containers, preventing them to be usable in sidecar mode (when set as init containers, alerts and notifier sidecars have hardcodedmethod#4045)This PR resolves the three issues by:
uMETHODon alerts and notifier containers whenrestartPolicyis defined and set toAlwaysPlease note that the behaviour of all 4 sidecar containers is not exactly homogeneous and I just tried to replicate their behavior of what's actually done when started as regular container
closes #4039, #4033, #4045 and possible #4031