[rollout-operator] add deployment annotations + allow not to create crds#4133
[rollout-operator] add deployment annotations + allow not to create crds#4133DrFaust92 wants to merge 4 commits intografana:mainfrom
Conversation
…e configuration Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
…e configuration Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
…e configuration Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com>
| apiVersion: apiextensions.k8s.io/v1 | ||
| kind: CustomResourceDefinition | ||
| metadata: | ||
| annotations: |
There was a problem hiding this comment.
I think there might be some extra spaces in front of annotations
|
hey @DrFaust92 ... could you double check on this PR. I don't think helm allows you add templating to the files in the crds directory. See https://helm.sh/docs/chart_best_practices/custom_resource_definitions/ The challenge with the crds is that if you move them into the templates folder then helm has ordering problems, as the crds need to be installed first. |
|
Good point! You're right that Helm doesn't template files in the However, a common pattern used by other charts (e.g., kube-prometheus-stack) is to use a CRDs subchart that:
I can refactor this PR to follow a similar approach — moving the CRDs into |
Hi @DrFaust92 - sorry for a delayed reply. Re your suggested refactor, sure I would be interested in seeing how this looks. Thank you! |
add deployment annotations + allow not to create crds
for clusters with instances of rollout operator, manage CRDs once