Fix the git describe in update-helm-repo to be Helm-centered#4185
Open
yorugac wants to merge 1 commit into
Open
Fix the git describe in update-helm-repo to be Helm-centered#4185yorugac wants to merge 1 commit into
git describe in update-helm-repo to be Helm-centered#4185yorugac wants to merge 1 commit into
Conversation
Contributor
Author
Contributor
Author
|
I've just tried the new release scheme (to have an app tag and Helm tag on the same commit): confirming this is a real issue. To bypass this, I had to delete the non-Helm tag manually (later re-create manually), to force Helm workflow to publish the chart properly in another run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Current
update-helm-repoworkflow decides whether to make a Helm chart release based on diff from the latest tag. But the latest tag may not necessarily be Helm-related which can lead to a wrong decision.Background. I'm currently re-working release procedure in k6-operator so that both the main app and Helm chart are published simultaneously, with automations. And in that case,
update-helm-repomay see the latest tag from the operator release (likev1.2.3) on HEAD and decide to skip the Helm release. To avoid that, it should instead check the latest Helm release tag which has a configured prefix.I was diagnosing this case with LLM's help, and this PR is meant to prevent a likely failure on the next release with my new release procedure. The fix adds stricter guarantees: