Root selector option for CSV/TSV#23
Open
yesoreyeram wants to merge 8 commits into
Open
Conversation
Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for applying root selectors (e.g., JSONata, GJSON, JQ) when converting CSV/TSV data to frames and refactors related rootselector logic in the jsonframer and csvframer packages.
- Introduce
FramerTypeandRootSelectorincsvframer.FramerOptionsplus a newApplyRootSelectorfunction to transform CSV arrays before framing. - Update
jsonframer/rootselector.goto special-case JSONata argument errors, and expandgframeralias-mapping logic. - Add golden test fixtures and a test suite for JSONata-based root selectors.
Reviewed Changes
Copilot reviewed 11 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/go/jsonframer/rootselector.go | Added strings import and special handling for JSONata “argument” errors |
| lib/go/gframer/gframer.go | Expanded alias/mapping condition to also apply when Selector == k |
| lib/go/csvframer/go.mod | Bumped jsonframer version and added new indirect dependencies |
| lib/go/csvframer/framer.go | Added FramerType & RootSelector options and new root-selector flow |
| lib/go/csvframer/framer_test.go | Added new test cases for CSV framing with JSONata root selector |
| lib/go/csvframer/testdata/with_root_selector_and_JSONata_framer/* | New golden JSONC fixtures covering various root selector scenarios |
Comments suppressed due to low confidence (1)
lib/go/csvframer/framer_test.go:93
- The new suite covers only
FramerTypeJsonata. Consider adding test cases for otherFramerTypeoptions likeFramerTypeGJSONandFramerTypeJQto ensure full coverage of the root-selector feature.
t.Run("with root selector and JSONata framer", func(t *testing.T) {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.