Expose a variety of mixins with customAllValue in their configuration#1594
Open
schmikei wants to merge 8 commits intografana:masterfrom
Open
Expose a variety of mixins with customAllValue in their configuration#1594schmikei wants to merge 8 commits intografana:masterfrom
customAllValue in their configuration#1594schmikei wants to merge 8 commits intografana:masterfrom
Conversation
customAllValue in their configuration
Contributor
Author
|
@Dasomeone the vsphere mixin stuff should be resolved in #1587 when we want to take a look at that otherwise I can make the identical updates in this PR as well. |
0ead66c to
1774774
Compare
Member
If you're fixing it in the other PR, then just move all the vsphere changes over to that one so linting will pass on this one :) Also apologies for missing that other PR, will have a look at that one tomorrow! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
fixes a Gitlab/Tensorflow render issues around imports inside other libraries.
It also models: Add
customAllValuesupport to docker, snmp, and windows observ libs #1595 to update a bunch of the mixins to expose the customAllValue so that the logslib can use the exposed parameterGitlab error while importing
Getting this while trying to render the dashboards for Gitlab within another repo.
Changing this import to this correctly resolves it