Skip to content

Expose a variety of mixins with customAllValue in their configuration#1594

Open
schmikei wants to merge 8 commits intografana:masterfrom
schmikei:fix/gitlab-broken-import
Open

Expose a variety of mixins with customAllValue in their configuration#1594
schmikei wants to merge 8 commits intografana:masterfrom
schmikei:fix/gitlab-broken-import

Conversation

@schmikei
Copy link
Contributor

@schmikei schmikei commented Feb 26, 2026

This PR

  1. fixes a Gitlab/Tensorflow render issues around imports inside other libraries.

  2. It also models: Add customAllValue support to docker, snmp, and windows observ libs #1595 to update a bunch of the mixins to expose the customAllValue so that the logslib can use the exposed parameter

Gitlab error while importing
RUNTIME ERROR: couldn't open import "../g.libsonnet": no match locally or in the Jsonnet library paths
        integrations/gitlab/vendor/gitlab-mixin/dashboards.libsonnet:1:11-34   thunk <g> from <$>
        integrations/gitlab/vendor/gitlab-mixin/dashboards.libsonnet:71:5-6
        integrations/gitlab/vendor/gitlab-mixin/dashboards.libsonnet:53:17-195
        integrations/gitlab/vendor/gitlab-mixin/dashboards.libsonnet:53:17-195  +:
        integrations/gitlab/vendor/gitlab-mixin/dashboards.libsonnet:(40:9)-(67:26)     object <anonymous>
        integrations/gitlab/vendor/gitlab-mixin/mixin.libsonnet:24:49-80   thunk from <thunk <dashboard> from <object <anonymous>>>
        integrations/gitlab/vendor/grafana-cloud-integration-utils/util.libsonnet:120:5-14  function <anonymous>
        integrations/gitlab/vendor/gitlab-mixin/mixin.libsonnet:24:25-108   thunk <dashboard> from <object <anonymous>>
        integrations/gitlab/vendor/gitlab-mixin/mixin.libsonnet:25:7-16 object <anonymous>
        Field "gitlab-logs.json"
        During manifestation

Getting this while trying to render the dashboards for Gitlab within another repo.

Changing this import to this correctly resolves it

@schmikei schmikei requested a review from a team as a code owner February 26, 2026 15:57
@schmikei schmikei changed the title fix gitlab import issue Expose a variety of mixins with customAllValue in their configuration Mar 3, 2026
@schmikei
Copy link
Contributor Author

schmikei commented Mar 3, 2026

@Dasomeone the vsphere mixin stuff should be resolved in #1587 when we want to take a look at that otherwise I can make the identical updates in this PR as well.

@schmikei schmikei force-pushed the fix/gitlab-broken-import branch from 0ead66c to 1774774 Compare March 3, 2026 16:17
@Dasomeone
Copy link
Member

Dasomeone commented Mar 3, 2026

@Dasomeone the vsphere mixin stuff should be resolved in #1587 when we want to take a look at that otherwise I can make the identical updates in this PR as well.

If you're fixing it in the other PR, then just move all the vsphere changes over to that one so linting will pass on this one :)

Also apologies for missing that other PR, will have a look at that one tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants