Conversation
Comment on lines
114
to
115
| width, | ||
| height, |
Collaborator
There was a problem hiding this comment.
What happens when the window's dimensions were saved when it was on a bigger screen and the width/height are now greater than what's available? Should there also be a check or is this handled automatically?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #1086
isWindowOnScreenhelper that checks if saved window bounds overlap any available display using Electron'sscreen.getDisplayMatching()APIx/ycoordinates so Electron auto-centers the window on the primary displayHow to Test
Checklist
Related PR(s)/Issue(s)
Note
Low Risk
Low risk: small, isolated change to window creation logic plus unit tests; main risk is incorrect bounds overlap logic causing windows to not restore to the intended position on some multi-monitor setups.
Overview
Prevents the app from restoring its main window to coordinates that are no longer visible (e.g., after monitor configuration changes).
Adds
isWindowOnScreen()(tested inwindow.test.ts) to detect whether saved window bounds overlap the current display work area, and inmain.tsonly applies savedx/ywhen the window would be on-screen; otherwise Electron falls back to default placement.Written by Cursor Bugbot for commit 91d6f78. This will update automatically on new commits. Configure here.